EnxDev commented on code in PR #45155: URL: https://github.com/apache/superset/pull/45155#discussion_r4256173533
########## superset-frontend/.npmrc: ########## @@ -1 +1,2 @@ min-release-age=3 +ignore-scripts=true Review Comment: This also turns off the `@scarf/scarf` postinstall, which is how the npm-install telemetry described in the FAQ (the Scarf section of `docs/docs/faq.mdx`) gets collected. It's a direct dependency with `scarfSettings` in `package.json`, so that looks deliberate. Fine if the project is happy to lose that signal, but it should be a decision and not a side effect. If it goes, the FAQ wants updating in the same PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
