aminghadersohi commented on PR #45231: URL: https://github.com/apache/superset/pull/45231#issuecomment-6142261543
Addressing the review from @EnxDev (https://github.com/apache/superset/pull/45231#pullrequestreview-5500260783): - Review body ("holds together… one design question inline"): no action needed; the static form, its startup validation and the fail-closed paths are unchanged. - Inline design question, `None` meaning deny-all with no way to say "tenant not scoped": fixed in b407e60cb582b27e5ba7258432f7063cd38d4862 by adding an explicit `UNSCOPED` sentinel, matched by identity. `None`, errors and invalid results still fail closed. Docs and tests are updated. Thread replied to and resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
