sadpandajoe commented on code in PR #44945:
URL: https://github.com/apache/superset/pull/44945#discussion_r4256808868
##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/RadioButtonControl.tsx:
##########
@@ -95,7 +95,6 @@ export default function RadioButtonControl({
}`}
onClick={e => {
e.currentTarget?.focus();
Review Comment:
The new guard still doesn't cover the Table column-config case.
`ControlFormItem` keeps `value` in state seeded with `defaultValue` and passes
that to the control, so `RadioButtonControl` receives `'right'` rather than
`undefined`; `initialValue === undefined` is false and clicking the highlighted
"Right" option still commits nothing. The unit test only exercises the control
mounted directly with no `value`, which isn't how `horizontalAlign` reaches it.
Can the default-commit be handled where the default is injected (or the guard
keyed on something the wrapper doesn't mask)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
