rusackas commented on PR #41907: URL: https://github.com/apache/superset/pull/41907#issuecomment-6142659040
@tomerkl65 checking back in, and thanks for getting the DISCUSS thread out on dev@. That was the piece I was waiting on, so I'll keep an eye on it. I'm leaving the `hold:sip!` label until it has run its course and the vote is done. While that plays out, there are a couple of things you can do that don't depend on the vote: - The branch has conflicts with master now (mostly around `Chart.tsx` and `ChartRenderer.tsx`), so it'll need a rebase at some point. - There are still a handful of open threads from @sadpandajoe's last round that look like real fixes rather than nits: Custom SQL (AdhocColumn) handling in the hierarchy control and `useDrillDownState`, gating the whole section on `DRILL_DOWN` instead of just the control, and the failed-drill path keeping stale state. Those would be good to settle before anyone does a final pass. No rush on my side, since nothing merges until the SIP is settled anyway. Holler if anything is unclear or you want a second pair of eyes on the thread, or want a hand with the SIP process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
