codeant-ai-for-open-source[bot] commented on code in PR #39614:
URL: https://github.com/apache/superset/pull/39614#discussion_r4258172419
##########
docker/pythonpath_dev/superset_config.py:
##########
@@ -151,3 +151,14 @@ class CeleryConfig:
)
except ImportError:
logger.info("Using default Docker config...")
+
+# ── Canias ERP iframe entegrasyonu ──────────────────────────────────────────
+# X-Frame-Options'ı devre dışı bırak (iframe içinde gösterim için)
+HTTP_HEADERS = {"X-Frame-Options": "ALLOWALL"}
+
+# Talisman (CSP) — iframe embed için gerekli
+TALISMAN_ENABLED = False
+
+# HTML sanitizasyonunu kapat (Markdown chart'larda custom HTML desteği)
+HTML_SANITIZATION = False
Review Comment:
**Suggestion:** Disabling sanitization lets raw HTML saved in dashboard
Markdown reach every viewer, where active HTML can execute in their Superset
session.
**Assessment:** 🔴 `Critical` · 🔁 `Occurrence: Rarely` · 🏷️ `Security`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=654339b9211f475dbcc7c2eace55837c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=654339b9211f475dbcc7c2eace55837c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docker/pythonpath_dev/superset_config.py
**Line:** 163:163
**Comment:**
*Security: Disabling sanitization lets raw HTML saved in dashboard
Markdown reach every viewer, where active HTML can execute in their Superset
session.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39614&comment_hash=d82e22ab863f3b126c4375550c9925d3e92f34b1c0545c09c59834c37dde99c6&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39614&comment_hash=d82e22ab863f3b126c4375550c9925d3e92f34b1c0545c09c59834c37dde99c6&reaction=dislike'>👎</a>
##########
tail_js_custom_extra.html:
##########
@@ -0,0 +1,14 @@
+<script nonce="{{ macros.get_nonce() }}">
+ window.addEventListener('message', function (event) {
+ if (!event.data) return;
+
+ if (event.data.type === 'SWITCH_TAB') {
+ var tabs = document.querySelectorAll('.ant-tabs-tab-btn');
+ if (tabs && tabs.length > event.data.tabIndex &&
event.data.tabIndex >= 0) {
+ tabs[event.data.tabIndex].click();
+ }
Review Comment:
**Suggestion:** When a page has multiple Ant tab groups, this indexes their
combined list, so a rotation message can activate an unrelated tab instead of
the dashboard tab.
**Assessment:** 🟠 `Major` · 🔁 `Occurrence: Rarely` · 🏷️ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d354bc8f56cd40a9b070c689afd116ca&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d354bc8f56cd40a9b070c689afd116ca&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tail_js_custom_extra.html
**Line:** 6:9
**Comment:**
*Logic Error: When a page has multiple Ant tab groups, this indexes
their combined list, so a rotation message can activate an unrelated tab
instead of the dashboard tab.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39614&comment_hash=3825f671343faf7b882638bf499f3d2497a6490b7fcf6aa235c0f98d43c1b8fc&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39614&comment_hash=3825f671343faf7b882638bf499f3d2497a6490b7fcf6aa235c0f98d43c1b8fc&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
