rusackas commented on PR #43182: URL: https://github.com/apache/superset/pull/43182#issuecomment-6149298474
Heya @bikash-barnwal, appreciate the work you put into this one, the before/after image size numbers up top are a nice bit of evidence for the change. It's stalled for a bit though. hainenber's changes-requested from a few weeks back is still open, and uyivzola found two real regressions testing `52f9ec5` on ARM64 with `DEV_MODE=false`: dropping `libecpg-dev` also drops the `ecpg` binary, which breaks `pgsanity`-based Postgres SQL validation, and `libldap2` doesn't exist on the Bookworm-based py311/py312 presets (needs `libldap-2.5-0` there). CI's green, but it doesn't actually exercise either path, so that's not reassuring here. uyivzola already put together a fix for both: https://github.com/uyivzola/superset/commit/6d10fd43e4f0f04a2bfc56ace53d50cc2f6dd996. Would you be up for pulling that in? If you're not up for maintaining this one any further, happy to either push it to this branch myself (maintainer edits are enabled on it) or adopt it as a fresh PR crediting your work, whichever you'd rather. Just let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
