sfirke commented on issue #26651: URL: https://github.com/apache/superset/issues/26651#issuecomment-6150575733
On the one hand, it's great that we have this almost ready to merge! On the other, it's not great process that above in this thread we have a detailed proposal on Sept 17th and then the other PR comes through Sept 22nd, jumping past the discussion. Great that it mostly lines up, but I think it's reasonable to delay merging it until it fulfills the stated plans in this SIP. My big question is, do we want this to be a separate new filter object instead of an improvement to the existing date filter? There is this comment above in this thread: > Reorganising into tabs, per @yousoph's mockups, which group the frames as > Absolute, Relative and Advanced. Probably the right end state and the grouping > question is already answered, but it is a much larger change than fixing the > default and is better proposed on its own. And then it got raised on the PR: https://github.com/apache/superset/pull/44527#discussion_r4129257804 If we create a second kind of date filter now, and then want to combine them in the future so that "simple calendar" moves to an option in the main date filter, how much extra difficulty + work are we incurring vs. making that decision now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
