glaterza opened a new issue, #45246: URL: https://github.com/apache/superset/issues/45246
### Problem Python-Nightly-Canary hits its 45-minute job timeout on almost half of its runs. GitHub then marks the run as cancelled, not failed. The `notify-on-failure` job uses `if: failure()`, so it skips on a cancelled run. No tracking issue opens. The 13 scheduled runs from 2026-10-01 to 2026-10-13: | Result | Runs | "Python unit tests" step | |---|---|---| | cancelled | 6 (Oct 1, 5, 7, 8, 11, 12) | 44.2 to 45.0 min | | success | 7 | 37.3 to 43.5 min | `notify-on-failure` skipped on all 13. Example cancelled run: https://github.com/apache/superset/actions/runs/38206654038 ### Root cause 1. The canary runs `pytest` serially. The test step alone takes 37 to 45 minutes, and the job limit is 45 minutes. 2. Python-Unit had the same problem and moved to `pytest -n auto --dist loadfile`. Its workflow comment says the serial suite had grown to about 27 to 28 minutes. The canary did not get the same change. 3. A job that reaches `timeout-minutes` ends as cancelled. `failure()` is false for a cancelled job, so `notify-on-failure` does not run. ### Steps to reproduce 1. Open the run list: https://github.com/apache/superset/actions/workflows/python-nightly-canary.yml 2. Open a cancelled run. The unit-test job ends with `The operation was canceled.` after about 45 minutes. The `notify-on-failure` job shows as skipped. ### Possible fixes - Run the canary's pytest step with `-n auto --dist loadfile`, as Python-Unit does. - Make `notify-on-failure` also run on a timeout. `cancelled()` also matches a run that `cancel-in-progress` stopped, so the condition may need to check the job result. I found this while I tested a separate change on my fork. I do not plan to work on it, but I can if nobody else does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
