sadpandajoe commented on code in PR #45244:
URL: https://github.com/apache/superset/pull/45244#discussion_r4261790122
##########
superset-extensions-cli/src/superset_extensions_cli/templates/frontend/package.json.j2:
##########
@@ -15,13 +15,14 @@
"description": "",
"peerDependencies": {
"@apache-superset/core": "*",
- "react": "^17.0.2",
- "react-dom": "^17.0.2"
+ "react": "^18.3.0",
+ "react-dom": "^18.3.0"
},
"devDependencies": {
+ "@apache-superset/core": "^0.1.0",
Review Comment:
Adding `@apache-superset/core` here means a freshly scaffolded extension
can't install. The published `@apache-superset/[email protected]` declares
`react`/`react-dom` peers of `^17.0.2`, while this template now requires
`^18.3.0`, so a plain `npm i` (which is what `superset-extensions build` runs
when `node_modules` is missing) fails with `ERESOLVE` unless
`--legacy-peer-deps` is passed. Did your manual `init --frontend` run use that
flag, or is a newer core release expected to widen its React range before this
lands?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
