glaterza commented on PR #45247: URL: https://github.com/apache/superset/pull/45247#issuecomment-6151354704
@hainenber Thanks for the review. What would you prefer here? My proposal is to remove `SUPERSET_GETTEXT_STRICT` and keep the rest: - Python-Unit and Python-Nightly-Canary install gettext. - The `python` and `python3` shims let the trailing-line test run where `/usr/bin` has no `python`. - The two msgcat tests skip when msgcat is missing, as on master. With gettext installed, both tests run and pass on CI. If a later change removes the gettext step, they skip again without a failure. Does that work for you, or do you have another approach in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
