villebro commented on code in PR #45253: URL: https://github.com/apache/superset/pull/45253#discussion_r4263013791
########## RELEASING/changelog.py: ########## @@ -25,7 +27,14 @@ from click.core import Context try: - from github import BadCredentialsException, Github, PullRequest, Repository + from github import ( + Auth, Review Comment: Valid, thanks. `github.Auth` only exists from PyGithub 1.59, and on older versions the import raises an `ImportError` that the script's `except ModuleNotFoundError` doesn't catch, so it fails with a raw traceback. Checking this also showed that the script relies on PyGithub's default rate-limit retry (`GithubRetry`), which only became the default in 2.1.1; 1.59 defaults to no retry and would fail on the first rate-limit error. PyGithub was only pulled in unpinned through cherrytree, so cd9271068e declares `PyGithub>=2.1.1` in `RELEASING/requirements.txt`. I ran the script on both 2.1.1 and 2.10.0 against the live API and got identical output, including the 404 fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
