codeant-ai-for-open-source[bot] commented on code in PR #39239:
URL: https://github.com/apache/superset/pull/39239#discussion_r4272646598
##########
superset-frontend/plugins/preset-chart-deckgl/src/components/Tooltip.tsx:
##########
@@ -58,7 +64,39 @@ const StyledDiv = styled.div<{
export default function Tooltip(props: TooltipProps) {
const { tooltip, variant = 'default' } = props;
- if (typeof tooltip === 'undefined' || tooltip === null) {
+ const [dismissed, setDismissed] = useState(false);
+ const wasVisibleRef = useRef(false);
+
+ // Reset dismissed when the tooltip transitions from hidden to visible. This
+ // handles the case where the cursor leaves the chart and re-enters a
+ // different pickable that happens to render the same content โ content
+ // alone wouldn't trigger a reset there.
+ useEffect(() => {
+ const isVisible = !!tooltip;
+ if (isVisible && !wasVisibleRef.current) {
+ setDismissed(false);
+ }
+ wasVisibleRef.current = isVisible;
+ }, [tooltip]);
+
+ // Reset on content change too (most common new-target signal).
+ useEffect(() => {
+ setDismissed(false);
+ }, [tooltip?.content]);
Review Comment:
**Suggestion:** After Escape dismisses the tooltip, hover updates for the
same pickable create new JSX content references, so this effect clears
dismissal and the tooltip reappears.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `State lifecycle`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f452cdeeae164fb4a6c6d7bfd1419ad2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f452cdeeae164fb4a6c6d7bfd1419ad2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/preset-chart-deckgl/src/components/Tooltip.tsx
**Line:** 83:85
**Comment:**
*State Lifecycle: After Escape dismisses the tooltip, hover updates for
the same pickable create new JSX content references, so this effect clears
dismissal and the tooltip reappears.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39239&comment_hash=4c75777350bed82381ccf59fc478f707862cbbc6710a8b1a9df5ee865e7efbbe&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39239&comment_hash=4c75777350bed82381ccf59fc478f707862cbbc6710a8b1a9df5ee865e7efbbe&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
