FrancescoCastaldi commented on PR #44945:
URL: https://github.com/apache/superset/pull/44945#issuecomment-6180611152
### Review Resolution Summary
All review comments have been resolved and verified with dedicated test runs:
1. **Test Assertion Alignment (`ControlForm.test.tsx`)**:
- In commit `db45fac32d`, updated the assertion at line 82 to expect two
calls (`expect(onChange).toHaveBeenCalledTimes(2)` and
`expect(onChange).toHaveBeenLastCalledWith({ horizontalAlign: 'right' })`).
- This matches the intentional re-click behavior where clicking an
already-selected option invokes `onChange` to allow re-applying uniform
dimensions in `ZoomConfigControl` or restoring drifted local state in
`ControlFormItem`.
- Verified that `ControlForm.test.tsx` passes cleanly, resolving the
previous failure in `sharded-jest-tests (1)`.
2. **Code Cleanup (`ControlFormItem.tsx`)**:
- Removed the dead `initialValue` prop forwarding to
`RadioButtonControl`, eliminating unused plumbing.
3. **Evidence Gate**:
- `Jest ControlForm.test.tsx`: PASS (1/1)
- `Jest RadioButtonControl.test.tsx`: PASS (41/41)
- `oxlint`: 0 warnings, 0 errors
- `oxfmt`: 100% formatted
@sadpandajoe, the assertion has been aligned with the re-click behavior and
all tests pass. The PR is ready for your re-review when convenient, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
