SEPURI-SAI-KRISHNA commented on code in PR #44953:
URL: https://github.com/apache/superset/pull/44953#discussion_r4278772855
##########
superset/models/helpers.py:
##########
@@ -2683,7 +2683,45 @@ def get_query_result(self, query_object: QueryObject) ->
QueryResult:
df = query_object.exec_post_processing(df)
except InvalidPostProcessingError as ex:
raise QueryObjectValidationError(ex.message) from ex
- except (TypeError, pd.errors.DataError) as ex:
+ # A post-processing operation is driven entirely by the request's
+ # `options` dict, which `ChartDataPostProcessingOperationSchema`
+ # accepts as an untyped `fields.Dict`. A malformed option therefore
+ # reaches pandas and surfaces as whatever pandas raises, so these
+ # are bad-request failures, not server faults. ImportError is
+ # deliberately excluded: a missing optional dependency (scipy, for
+ # a `rolling` win_type) is a deployment matter, not a bad request.
+ except KeyError as ex:
+ # Every KeyError a built-in operation raises names a column or
+ # MultiIndex level the options asked for and the result does
+ # not have. `str(KeyError)` is only the repr'd key, which alone
+ # reads as a bare quoted string. An operation registered
+ # through EXTRA_PANDAS_POSTPROCESSING_OPS could raise KeyError
+ # from its own internals, where that wording would be a guess,
+ # which is the other reason to keep the traceback.
+ logger.warning(
+ "Post-processing failed and was reported as a bad request",
+ exc_info=True,
+ )
+ raise QueryObjectValidationError(
+ _(
+ "Post-processing references a column or level that is "
+ "not in the query result: %(name)s",
+ name=ex.args[0] if ex.args else ex,
+ )
+ ) from ex
+ except (
+ TypeError,
+ ValueError,
+ AttributeError,
+ pd.errors.DataError,
+ ) as ex:
Review Comment:
One correction to my reply above: I wrote "This file is back to master byte
for byte", which contradicts the sentence before it and is wrong either way.
Removing the call-site handlers is itself a change, so both files differ from
master by exactly those deletions:
```
superset/models/helpers.py | 2 --
superset/semantic_layers/models.py | 3 ---
```
The rest of that reply holds. The wrapping lives in
`QueryObject._exec_operation`, only built-in operations are converted, and a
fault inside an operation registered through `EXTRA_PANDAS_POSTPROCESSING_OPS`
propagates as a server error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
