FrancescoCastaldi commented on PR #43695: URL: https://github.com/apache/superset/pull/43695#issuecomment-6193258018
Addressed all 4 review follow-ups in commit `d49752d`: 1. **`test_databricks.py`**: Added `"encryption": False` to both `build_sqlalchemy_uri` parameter dicts, satisfying `DatabricksBaseParametersType` and clearing mypy. 2. **`test_databricks.py`**: Added unit test case verifying the `uri.database or "default"` fallback in `adjust_engine_params` when connecting without database or schema. 3. **`test_lint_metadata.py`**: Populated all required fields (`description`, `categories`, `pypi_packages`, `connection_string`) in `test_main_ascii_stdout_markdown_report` so `✓` is emitted in the markdown table, and asserted it survives UTF-8 decode without `UnicodeEncodeError`. 4. **`databricks.py`**: Folded `effective_catalog` into `if effective_catalog := catalog or original_catalog:` to satisfy `auto-walrus` and `ruff-format` pre-commit hooks. @sadpandajoe Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
