moonpigeonnnnnn commented on issue #45340:
URL: https://github.com/apache/superset/issues/45340#issuecomment-6192931935

   > 2\. Hi, I'd like to work on this. With no column passed, get_time_filter() 
leaves target_type empty, so ClickHouse's convert_dttm returns None and 
remove_filter does nothing. I'd fall back to the column of the TEMPORAL_RANGE 
filter for both, with tests in jinja_context_test.py.
   
   Unfortunately, I don't have the ability to run tests in the 
jinja_context_test.py, but I found a solution.
   
   Adding the `target_type="DATE"` parameter resolves everything, apparently it 
is necessary. As expected something simple I was missing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to