tien238lnd commented on PR #45176: URL: https://github.com/apache/superset/pull/45176#issuecomment-6196674518
Addressed @mikebridge's review in the latest push: with `SEMANTIC_LAYERS` off, a saved `source_type` is no longer sent to `/api/v1/dataset/`, and a saved `sl:` connection is neither sent as `semantic_layer_uuid` nor kept in the filter state (it is cleared through the same `clearFilterById` the cascade uses), so a rolled-back deployment does not leave the list stuck on a rejected request. Two regression tests mount the page with those saved URLs (the render helper now accepts initial route entries); both failed before the change, all 7 DatasetList suites / 132 tests pass. The OpenAPI drift check was master being red on #45071 and is green again; the Jest shard 3 failure is `AddSemanticViewModal` (not touched here). _🤖 Addressed by [Claude Code](https://claude.com/claude-code)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
