mikebridge commented on PR #45349:
URL: https://github.com/apache/superset/pull/45349#issuecomment-6199149843
Re CodeAnt's note on null keys inside arrays: confirmed and fixed in
ccc72393a3. `_without_null_values` now recurses into list items, so
`{"folders": [{"name": "Sales", "description": null}]}` and `{"folders":
[{"name": "Sales"}]}` compare equal, as the docstring promised. New red-first
case: `null-key-in-object-in-array` in `test_equivalent_extra_is_not_an_edit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
