willbarrett commented on a change in pull request #8773: re-enable Pylint on a
number of view files
URL:
https://github.com/apache/incubator-superset/pull/8773#discussion_r356216882
##########
File path: superset/views/sql_lab.py
##########
@@ -176,13 +177,14 @@ def show(self, pk):
appbuilder.add_view_no_menu(SavedQueryView)
-class TabStateView(BaseSupersetView):
- def _get_owner_id(self, tab_state_id):
- return
db.session.query(TabState.user_id).filter_by(id=tab_state_id).scalar()
+def _get_owner_id(tab_state_id):
+ return
db.session.query(TabState.user_id).filter_by(id=tab_state_id).scalar()
+
+class TabStateView(BaseSupersetView):
@has_access_api
@expose("/", methods=["POST"])
- def post(self):
+ def post(self): # pylint: disable=no-self-use
Review comment:
I think it's valuable outside of this context. As I was doing this work, I
identified quite a few methods that could be refactored out of a large class
into a stand-alone function. I'd like to keep the rule for those instances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
