aminghadersohi commented on PR #45348: URL: https://github.com/apache/superset/pull/45348#issuecomment-6201763661
Fixed the stale description in 98a05a717c1ed67250f39b1ab7a0b0cbcf320a9d. For the test-count note in https://github.com/apache/superset/pull/45348#pullrequestreview-5538644682 : I replaced the stale counts and historical live-worker claims in the PR description. At 98a05a717c1ed67250f39b1ab7a0b0cbcf320a9d, `test_async_results.py` contains 121 cases: 117 fail against the merge-base and 4 pass (three status guards plus the MessagePack payload-shape test). The latter is explicitly identified as existing-behavior coverage, not proof of the original decoding repair. Regression tests for this revision include `tests/unit_tests/sql/execution/test_async_results.py::test_async_payload_uses_one_arrow_format` and `::test_corrupt_cache_is_a_miss`, failing at c310e0254be44e31cb44d5b398273319b253b829 and passing at 98a05a717c1ed67250f39b1ab7a0b0cbcf320a9d. Validation: `pytest tests/unit_tests/sql/execution/test_async_results.py tests/unit_tests/sql/execution/test_celery_task.py -q -m "not manual and not llm_compliance"` gives 21 failed / 148 passed with source at c310e0254be44e31cb44d5b398273319b253b829, and 169 passed at 98a05a717c1ed67250f39b1ab7a0b0cbcf320a9d. The SQL plus result-set suites give 2,461 passed; staged pre-commit and mypy pass. Siblings checked: - tests/unit_tests/sql/execution/test_async_results.py — fixed in 98a05a717c1ed67250f39b1ab7a0b0cbcf320a9d - tests/unit_tests/sql/execution/test_celery_task.py — fixed in 98a05a717c1ed67250f39b1ab7a0b0cbcf320a9d - docs/developer_docs/extensions/mcp.md — not affected: contains no test-count claims. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
