geido commented on PR #45273: URL: https://github.com/apache/superset/pull/45273#issuecomment-6202620746
@alexandrusoare heads-up since your approval was on 7d80473: three commits landed after it. - 3e7d3a1 applies the same helper to the legacy `POST /api/v1/query/` (`Api.query`), which returns the same `get_payload()["queries"]` list as chart data ([call](https://github.com/apache/superset/blob/3f5800786a70d041958c1e0fea10ad6b8fee92d4/superset/views/api.py#L81)). Covered by [`test_api_query_redacts_generated_sql_for_guests`](https://github.com/apache/superset/blob/3f5800786a70d041958c1e0fea10ad6b8fee92d4/tests/unit_tests/views/test_base.py#L350) and [`test_api_query_keeps_payload_for_regular_users`](https://github.com/apache/superset/blob/3f5800786a70d041958c1e0fea10ad6b8fee92d4/tests/unit_tests/views/test_base.py#L365); removing the new line makes the guest test fail. The frontend never POSTs to this endpoint, so there's no UI change. - a82a73d tightens the samples test (see the thread on `views_test.py`); 3f58007 is comment and docstring wording only. @EnxDev thanks for the second pass on 3f58007. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
