sadpandajoe commented on issue #45265: URL: https://github.com/apache/superset/issues/45265#issuecomment-6203392999
> Thanks [@sadpandajoe](https://github.com/sadpandajoe), that makes sense, and I'm happy to ship this as an extension so people can opt in. > > Two questions so I can rework it the right way: > > 1. Can an extension register a new viz type together with its frontend plugin (control panel, lazy-loaded chart component), or is there a recommended pattern for chart plugins in the extensions framework? > 2. The Excel export needs a backend hook: for this viz type, the XLSX chart-data export writes the formatted sheet instead of the raw dataframe (today a small branch in `QueryContextProcessor` calling `univer_excel`). Is there, or would you accept, an extension point for a per-viz-type export formatter, so the extension can provide it without changing core? > > The two small PRs are generic and useful without this chart, so I'd suggest reviewing them independently of the SIP: > > * [fix(post-processing): flatten every index level #45263](https://github.com/apache/superset/pull/45263): fixes `flatten` dropping index levels after a multi-index pivot (already reviewed). > * [feat(explore): pass appSection to chart plugins #45275](https://github.com/apache/superset/pull/45275): passes `appSection` from `ChartRenderer` to chart plugins, so any plugin (including extensions) can tell Explore from a dashboard. I'll push the `?standalone=2` fix from review shortly. > > I'll update the SIP once the extension approach is clear. @rusackas @michael-s-molina is this possible now with extensions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
