codeant-ai-for-open-source[bot] commented on code in PR #45364:
URL: https://github.com/apache/superset/pull/45364#discussion_r4288929581
##########
superset/initialization/__init__.py:
##########
@@ -151,9 +151,21 @@ def configure_celery(self) -> None:
# setup properly
task_base = celery_app.Task
+ # ``celery_app`` is a process-wide singleton, so a second
initialization
+ # in the same process (the unit suite builds one app per test module)
+ # finds the wrapper installed by the previous one. Wrap the original
+ # base again instead of wrapping the wrapper: a chain of wrappers keeps
+ # every app ever initialized reachable through the task class
+ # hierarchy, and the suite's memory then grows with every module. Only
+ # this method installs the marked wrapper, so one level is unwrapped.
+ if "_superset_app_context_task" in vars(task_base):
+ task_base = task_base._superset_task_base
Review Comment:
**Suggestion:** Already registered task classes still inherit the old
wrapper, keeping its `superset_app` alive and using that stale app context
after reinitialization.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Stale reference`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=1347c82ae47b449f8a9ca47f11acb06d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=1347c82ae47b449f8a9ca47f11acb06d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/initialization/__init__.py
**Line:** 162:162
**Comment:**
*Stale Reference: Already registered task classes still inherit the old
wrapper, keeping its `superset_app` alive and using that stale app context
after reinitialization.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45364&comment_hash=71f4bb5cc2aeb1de49f8c294a25922975a410260e80c82b9149ff97faf61fdb2&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45364&comment_hash=71f4bb5cc2aeb1de49f8c294a25922975a410260e80c82b9149ff97faf61fdb2&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
