aminghadersohi commented on PR #45232: URL: https://github.com/apache/superset/pull/45232#issuecomment-6205849087
@rebenitez1802 thanks. What closed each heads-up, at c78bdb1577234511e7769fe099e4b6326cc768a9 (master merged, including https://github.com/apache/superset/pull/45283): - `impala.py` conflict: Impala SQL Lab stops stay cursor-only. There is no HTTP cancel and no `QUERY_CANCEL_KEY` lookup on that path, so the `NameError` can't happen. `tests/unit_tests/db_engine_specs/test_impala_pending.py::test_stop_running_query_uses_live_cursor` and `tests/unit_tests/daos/test_query_dao.py::test_engine_early_cancel_commits_with_guarded_stop` pass at this head and fail with master's Impala preparation restored. - `test_executor_cancel_does_not_commit_caller_session`: I kept master's committing `_cancel_async_query` and removed this test, since it asserted the opposite. - `trino.py:413-415` nit: no longer applies. Master's Celery `_handle_query_error` now keeps accepted STOPPED outcomes too. Siblings checked: `superset/sql_lab.py` and `superset/sql/execution/executor.py` — fixed in c78bdb1577234511e7769fe099e4b6326cc768a9; `superset/tasks/query_cancel.py` — not affected: chart and MCP cancellation call the engine HTTP cancel directly and bypass SQL Lab preparation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
