rusackas commented on code in PR #43471:
URL: https://github.com/apache/superset/pull/43471#discussion_r4289991350
##########
UPDATING.md:
##########
@@ -958,6 +959,32 @@ MCP `list_metrics`). The server never adds a missing
marker from metadata.
Explore query controls remain unavailable until explicit field initialization,
so legacy filter subjects cannot trigger value suggestions before reselection.
+### Superset no longer auto-generates `type:`/`editor:`/`favorited_by:` tags
+
+With `TAGGING_SYSTEM` enabled, Superset used to auto-tag every chart,
+dashboard, saved query, and dataset with implicit tags derived from
+metadata (object type, editors, and who favorited it), and generate a
+`favorited_by:<user id>` tag on every favorite/unfavorite. Nothing in the
+UI ever surfaced these tags to users — every tags list and filter in the
+frontend explicitly excluded them — so the generation added continuous
+write overhead (13 SQLAlchemy event listeners across 5 models) with no
+user-visible benefit. That generation is removed.
+
+Manually-created (custom) tags are unaffected: creating, editing,
+listing, and filtering tags still works exactly as before, including the
+`custom_tag` API filter used to distinguish custom from implicit tags.
+
+Deployments already running with `TAGGING_SYSTEM` enabled keep any
+`type:`/`editor:`/`favorited_by:` tag rows created before upgrading — they
+remain queryable via the API and MCP's `list_tags`/`get_tag_info` tools,
+and are still exempt from bulk tag deletion — but no new ones are created,
+and the `superset sync_tags` CLI command that backfilled them has been
+removed. The `DASHBOARD_LIST_CUSTOM_TAGS_ONLY` config flag and the
Review Comment:
Took the suggestion, `UPDATING.md` now says the retained rows are a frozen
snapshot that drifts and need manual cleanup.
##########
superset/tags/core.py:
##########
@@ -50,84 +56,28 @@ def _tag_delete_listener_declarations() ->
tuple[DeleteListenerDeclaration, ...]
DeleteListenerEffect.PERSISTENT_RECORD,
DashboardUpdater.after_delete,
),
+ DeleteListenerDeclaration(
+ SavedQuery,
+ "tagged_object_cleanup",
+ DeleteListenerEffect.PERSISTENT_RECORD,
+ QueryUpdater.after_delete,
+ ),
Review Comment:
Added `test_tagged_object_cleanup_on_object_delete` covering chart and saved
query deletion. Dataset deletion is still uncovered since it needs a database
fixture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
