codeant-ai-for-open-source[bot] commented on PR #35542: URL: https://github.com/apache/superset/pull/35542#issuecomment-6208646090
## CodeAnt PR Risk: High Risk - The PR should not merge yet: allowing duplicate tag names makes existing name-only deletion paths capable of deleting both custom and system tags. - The migration drops a hard-coded tag_name_key; databases that named the original unique index differently can fail superset db upgrade. - The duplicate cleanup can delete referenced duplicate NULL-name tags, causing the migration to fail where foreign keys are enforced. **Assessed commit:** `dad96b22fa76` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
