eschutho commented on PR #44431: URL: https://github.com/apache/superset/pull/44431#issuecomment-6208791179
@rusackas the merge conflict blocking this is cleared. The head is now c1a1a3ed33 and GitHub reports it as mergeable. The base branch had been rebased onto master, so I merged its new tip into this branch (no force-push). One resolution choice worth a look: re-pointing the default datetime column now leaves the value transform behind and the mapping arrives inert, which is the base's behaviour. The earlier carry-the-transform version on this branch looked like an accidental revert of the base's fix (details in the message of merge commit ccf35ee674). Your 10/2 note said the engine gating makes sense, and your exploreReducer.ts concern was fixed in the 10/6 round. The fast checks (lint, license, translations, deps, migration head) are green. The full test matrix is still running, with nothing failed so far. Ready for another look or approval when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
