FrancescoCastaldi commented on PR #45186:
URL: https://github.com/apache/superset/pull/45186#issuecomment-6214366878
### Update Summary (Commit `1ea0c24da6`)
This update addresses review feedback from @sadpandajoe:
1. **Core Package Dependency Bounds (`superset-core/pyproject.toml`)**:
- Replaced `pyarrow>=25.0.1, <26` with `pyarrow>=23.0.1` (without an
upper ceiling).
- Preserves installation compatibility for downstream extensions and
custom environments (e.g., pinning `pyarrow==24.0.0`) while satisfying the
fixed floor for CVE-2026-25087. The narrower `>=25.0.1, <26.0.0` bound remains
enforced at the root application layer and in container builds.
2. **Remediation Guide Restructuring
(`docs/admin_docs/security/dependency-vulnerability-remediation.mdx`)**:
- Explicitly clarified the distinction between:
- **Package Declarations (`pyproject.toml`,
`superset-core/pyproject.toml`)**: flexible library version ranges for resolver
compatibility.
- **Resolver Constraints Input (`requirements/base.in`)**: candidate
ranges and security floors supplied to `pip-compile`.
- **Locked Requirements (`requirements/base.txt`)**: exact pinned
versions and hashes for deterministic Docker containers and CI.
3. **Release Notes (`UPDATING.md`)**:
- Updated the entry under `## Next` to reflect the relaxed core
constraint.
4. **Snowflake Keypair Hardening & Tests
(`superset/db_engine_specs/snowflake.py`,
`tests/unit_tests/db_engine_specs/test_snowflake.py`)**:
- Hardened `update_params_from_encrypted_extra` to safely handle
null/empty `auth_params` and empty passphrases.
- Added unit tests covering null/empty dictionary states and unencrypted
PEM keys.
### Evidence Gate Verification
- Unit tests: `python -m pytest
tests/unit_tests/db_engine_specs/test_snowflake.py -k
test_snowflake_update_params` (6 passed, 0 failed).
- Line-length & Linter: `python -m ruff check` clean, all lines strictly
within 88 columns.
@sadpandajoe, both feedback items have been addressed and validated. The PR
is ready for your re-review when convenient, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
