nicob3y commented on PR #40919: URL: https://github.com/apache/superset/pull/40919#issuecomment-6219549657
Hi @sadpandajoe, @rusackas, I have refactored my approach to better align with the core architecture. Here is a summary of the changes: - Separation display vs. logic: I am now using translatable labels strictly for rendering and display purposes. By isolating these display-only instances, the underlying query and SQL generation logic should remain untouched. However, I might have missed an edge case somewhere, so this part definitely requires careful vigilance and a close review. - This localization capability is now gated behind a configuration key, meaning the application's default behavior remains completely unchanged. - I moved the frontend constant declarations into the @superset-ui-core package. This makes them globally available and eliminates duplicate declarations across the codebase. - Since these labels might eventually be needed on the backend as well, the translations are driven from the backend and seamlessly passed down to the frontend. Additionally, I have updated all the impacted unit tests to validate these changes. What do you think of this approach? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
