codeant-ai-for-open-source[bot] commented on code in PR #45380:
URL: https://github.com/apache/superset/pull/45380#discussion_r4297066748
##########
tests/unit_tests/importexport/api_test.py:
##########
@@ -258,6 +258,48 @@ def test_import_assets_not_zip(
}
+def test_import_assets_corrupt_zip(
+ mocker: MockerFixture,
+ client: Any,
+ full_api_access: None,
+) -> None:
+ """
+ Test that a ZIP with a corrupt central directory returns a 422, not a 500.
+ """
+ buf = BytesIO()
+ with ZipFile(buf, "w") as bundle:
+ bundle.writestr("bundle/metadata.yaml", "version: 1.0.0\n")
+ corrupt = BytesIO(buf.getvalue().replace(b"PK\x01\x02", b"XXXX"))
+ assert is_zipfile(corrupt)
Review Comment:
**Suggestion:** `is_zipfile(corrupt)` leaves the stream at its end, so the
multipart request uploads an empty file and tests the “Not a ZIP file” path
instead.
**Assessment:** 🟠 `Major` · 🔁 `Occurrence: Often` · 🏷️ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=24024a3d1baa4fe49af3ded91f619272&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=24024a3d1baa4fe49af3ded91f619272&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/importexport/api_test.py
**Line:** 273:273
**Comment:**
*Logic Error: `is_zipfile(corrupt)` leaves the stream at its end, so
the multipart request uploads an empty file and tests the “Not a ZIP file” path
instead.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45380&comment_hash=bf2c625cb6f5deef208be8c4f0571e6b2022dacf8ea63154d481f6635ccc0bda&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45380&comment_hash=bf2c625cb6f5deef208be8c4f0571e6b2022dacf8ea63154d481f6635ccc0bda&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
