younsl opened a new pull request, #449:
URL: https://github.com/apache/superset-kubernetes-operator/pull/449

   ## Summary
   
   The lifecycle guide has three small mistakes where it disagrees with the 
code or with itself. The worst one is the seed image table: it lists the source 
types in lowercase, but the CRD enum only accepts PostgreSQL and MySQL, so 
copying the value from the table fails validation. This PR fixes all three. It 
changes docs only.
   
   ## Details
   
   - Seed Image table: postgresql and mysql become PostgreSQL and MySQL, 
matching the enum on SeedSourceSpec.Type in api/v1alpha1/superset_types.go.
   - Disabling Tasks: the paragraph about what happens to a disabled task (Job 
and ConfigMap deleted, status cleared, no propagation) was at the end of the 
external CronJob part of Scheduled Execution. It now follows the disabled: true 
example it describes. The text itself is unchanged.
   - Pipeline Checksum Model: the migrate line of the checksum chain now 
includes createDatabase. The trigger table at the top of the same page and 
migrateInputs in internal/controller/lifecycle_migrate.go already include it.
   
   <details>
   <summary>Verification</summary>
   
   - make lint-md passes.
   - mkdocs build in strict mode passes with the pinned docs requirements.
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to