younsl opened a new pull request, #450:
URL: https://github.com/apache/superset-kubernetes-operator/pull/450

   ## Summary
   
   Three examples in the user guide do not match what the operator and the Helm 
chart do. One of them fails on apply: the websocket routing example in the 
migration guide sets an Ingress without a web server, which the CRD rejects. 
The other two give readers wrong information about which components can 
autoscale and which Service name to put in the metrics TLS config. This PR 
fixes all three. It changes docs only.
   
   ## Details
   
   - migration.md, Websocket Routing: the Ingress example now includes 
webServer. Without it the CEL rule "spec.networking.ingress requires 
spec.webServer to be set" rejects the resource. The Gateway API example right 
after it is fine as is, because a websocket server alone is enough for a 
gateway.
   - migration.md, feature table: the Autoscaling row now lists MCP next to 
Flower and websocket. McpServerComponentSpec embeds ScalableComponentSpec, and 
the PDB row later in the same guide already lists the MCP server.
   - networking-and-monitoring.md, metrics TLS example: serverName was a 
release-name placeholder followed by superset-operator-metrics. The chart names 
the Service with its fullname helper, which drops the chart name when the 
release name already contains it. With the release name from the install guide 
the Service is superset-operator-metrics, so the example now uses that name and 
notes which release name it assumes.
   
   <details>
   <summary>Verification</summary>
   
   - helm template with release name superset-operator and metrics enabled 
renders the Service as superset-operator-metrics. With release name my-ops it 
renders my-ops-superset-operator-metrics.
   - make lint-md passes.
   - mkdocs build in strict mode passes with the pinned docs requirements.
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to