mikebridge opened a new pull request, #45388: URL: https://github.com/apache/superset/pull/45388
### SUMMARY **TL;DR:** The chart, dashboard, and dataset delete controls now say “Archive” when soft delete makes the action recoverable. **Background:** Superset already uses archive wording in the main list confirmations. **Problem:** Several card actions, dashboard card confirmations, and disabled permission hints still described that same action as permanent deletion. **What this changes:** - Uses the existing Archive/Delete action-label helper on dashboard cards. - Gives dashboard card dialogs the existing archive title, recoverability explanation, and confirmation mode when soft delete is enabled. - Uses archive wording in disabled chart, dashboard, and dataset permission hints. - Preserves Delete wording and the type-DELETE confirmation when soft delete is disabled. Semantic views remain permanently deleted and retain Delete wording. The detailed design follows: these are frontend copy and confirmation settings for existing delete requests; no API or persistence behavior changes. | Surface | Soft delete enabled, before | Soft delete enabled, after | Soft delete disabled | | --- | --- | --- | --- | | Dashboard card action | Delete | Archive | Delete | | Dashboard card confirmation | “Please confirm” and type DELETE | “Archive <dashboard>?” and recoverability explanation; no typing gate | Unchanged “Please confirm” and type DELETE | | Disabled chart/dashboard/dataset action | “in order to delete” | “in order to archive” | Unchanged “in order to delete” | ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Text-only changes are summarized in the table above. ### TESTING INSTRUCTIONS 1. Enable `SOFT_DELETE`. Open a dashboard card’s action menu from Home and the dashboard list card view. Confirm the action says **Archive**, the dialog names the dashboard, explains Recently Archived recovery, and does not require typing DELETE. 2. With `SOFT_DELETE` disabled, repeat those flows. Confirm they say **Delete** and still require typing DELETE. 3. With write permission but without editorship, hover disabled chart, dashboard, and dataset delete controls in card/list views. Confirm the hint says **archive** with the flag on and **delete** with it off. 4. Automated verification: 7 focused Jest suites passed (104 tests). Changed-file pre-commit passed, including targeted TypeScript checking. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Required feature flags: `SOFT_DELETE` - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
