rusackas commented on PR #42841: URL: https://github.com/apache/superset/pull/42841#issuecomment-6221897876
Thanks @DanRoscigno, routing `x_axis` by payload shape is a sensible way out of the double-duty key, and the tests cover the cases well. LGTM from me once you've decided what to do with @aminghadersohi's nit about all-mistyped styling keys (fine to leave as is if it's rare, but safer is always better). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
