sadpandajoe commented on code in PR #44101:
URL: https://github.com/apache/superset/pull/44101#discussion_r4299663380
##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -521,6 +527,31 @@ const RightMenu = ({
}
});
+ const extensionSettingsItems = (settingsMenuExtension?.primary ?? [])
+ .map(menuItem => {
+ const command = commands.getCommand(menuItem.command);
+ if (!command) {
+ return null;
+ }
+ return {
+ key: command.id,
Review Comment:
Using the raw `command.id` as the menu key means an extension command whose
id equals a built-in key (e.g. `dbconnection`, `gsheets`, `csvUpload`) also
reaches the parent Menu's `handleMenuSelection`. Clicking that Settings entry
would run the extension callback and open the built-in modal too. Could the
extension item get its own namespaced key (e.g. `extension:${command.id}`)
while `executeCommand` keeps the original id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
