iamthisal opened a new pull request, #45420:
URL: https://github.com/apache/superset/pull/45420
### SUMMARY
The Explore "Actual range for comparison" label can display an outdated
range when an earlier time-range request resolves after the selected comparison
shift changes.
Add an effect-scoped cancellation flag so results from an obsolete effect do
not update the label after a settings change or unmount. The request helper and
API remain unchanged.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not included; this is a timing-dependent label update.
### TESTING INSTRUCTIONS
1. In Explore, use a chart with Time Comparison (for example, Table) and a
temporal filter.
2. Enable slow network throttling in browser DevTools. Select a Time shift,
then switch to another shift while the time-range request is pending.
3. Check that "Actual range for comparison" reflects the latest shift,
including when the earlier request finishes last.
4. Clear the Time shift while a request is pending and confirm the old label
does not reappear.
Automated tests were not run locally: the npm registry returned HTTP 403
while installing frontend dependencies. This change does not include a
regression test.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
