schizophrenicmaniac opened a new pull request, #45427: URL: https://github.com/apache/superset/pull/45427
### SUMMARY About 8% of the Slovak catalog is actually Czech, mostly since #40219. This is the stopgap suggested in #45377: every sk `msgstr` containing ě, ř or ů (letters that don't exist in Slovak) is cleared, so those strings fall back to English until someone provides a real Slovak translation. That's 388 entries, 5 of them plural (all forms cleared). 35 were marked `#, fuzzy`; the flag is dropped along with the text, the same as in #44611. Nothing else in the file changes: I edited the entries in place rather than re-saving the catalog with polib/babel, because that rewraps the whole file. A polib comparison against master shows every other entry is identical. I also added a small regression test next to the existing sk placeholder test, so these letters can't come back into the sk catalog unnoticed (for example through a backfill). This doesn't cover the wider review of the ~1,160 entries identical to `cs`. Many of those are legitimately spelled the same, and sorting them out needs a native speaker. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No screenshots yet, still to be added. With the UI in Slovak, strings like the month names (`Březen`, `Říjen`), `Řadit` and `Odhad nákladů` showed up in Czech before. Now they show in English. ### TESTING INSTRUCTIONS 1. Run the count from the issue: `pip install polib`, then the snippet in #45377 against `superset/translations/sk/LC_MESSAGES/messages.po`. It prints 0 (388 on master). 2. `pytest tests/unit_tests/translations/` passes; the new `sk_czech_letters_test.py` fails on master. 3. Compile the catalog (`pybabel compile -i superset/translations/sk/LC_MESSAGES/messages.po -o /tmp/messages.mo -l sk`). It still builds. 4. Optionally, build translations, switch the UI to Slovak and check that e.g. the date picker months and "Sort" now show in English rather than Czech. ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #45377 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
