codeant-ai-for-open-source[bot] commented on code in PR #45439:
URL: https://github.com/apache/superset/pull/45439#discussion_r4306746369
##########
superset/charts/client_processing.py:
##########
@@ -851,18 +869,37 @@ def format_column(
parallel ``currency_context`` series is present, AUTO uses each row/cell's
contributing currencies first. Mixed context renders a neutral number;
empty context optionally falls back to query-wide detection.
+
+ ``small_d3_format`` is the column's small-number format. The choice is per
+ cell rather than per column, matching ``formatColumnValue``: a value below
+ one in absolute value takes that format with the column config's own
+ currency, exactly what ``getSmallNumberFormatter`` builds, and every other
+ value keeps the column's normal format.
"""
- if d3_format or currency.get("symbol"):
+ if d3_format or currency.get("symbol") or small_d3_format:
if currency_context is None:
resolved_currency = resolve_auto_currency(currency,
detected_currency)
- df[column] = df[column].apply(
- partial(format_number_with_config, d3_format,
resolved_currency)
+ format_value = partial(
+ format_number_with_config, d3_format, resolved_currency
)
+ if small_d3_format:
+ format_small = partial(
+ format_number_with_config, small_d3_format, small_currency
or {}
+ )
+ df[column] = df[column].apply(
+ lambda value: format_small(value)
+ if is_small_number(value)
+ else format_value(value)
+ )
+ return
+ df[column] = df[column].apply(format_value)
return
contexts = currency_context.reindex(df.index)
df[column] = [
- format_number_with_config(
+ format_number_with_config(small_d3_format, small_currency or {},
value)
+ if small_d3_format and is_small_number(value)
Review Comment:
**Suggestion:** This small-number path ignores row currency context, so
values in AUTO-formatted columns lose their per-row currency symbol in reports.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a5d0f6676bdb4484b8aaf3f161186417&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a5d0f6676bdb4484b8aaf3f161186417&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/charts/client_processing.py
**Line:** 900:901
**Comment:**
*Api Mismatch: This small-number path ignores row currency context, so
values in AUTO-formatted columns lose their per-row currency symbol in reports.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45439&comment_hash=279f159b13207436468330f9f1bd2e5f8afd2ed43e28617c38b5149024db61df&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45439&comment_hash=279f159b13207436468330f9f1bd2e5f8afd2ed43e28617c38b5149024db61df&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
