geido commented on code in PR #45266:
URL: https://github.com/apache/superset/pull/45266#discussion_r4308642112
##########
superset/views/datasource/views.py:
##########
@@ -142,10 +145,14 @@ def _repoints_sql(
or requested_sql != datasource.sql
or (requested_table.schema, requested_table.catalog)
!= (datasource.schema or None, datasource.catalog or None)
+ or json_to_dict(requested_template_params or "")
Review Comment:
Added in 4b47324: `test_save_rejects_template_params_repoint_without_access`
saves `SELECT * FROM {{ t }}` with SQL, database, schema and catalog unchanged
and only `t` different, has the SQL check deny, and asserts
`DatasetForbiddenError`, that `raise_for_access` got the new params with
`allow_editorship=False`, and that `update_from_object` was not called. Also
added `test_save_rejects_unreadable_template_params` (422, nothing written) and
`test_save_rechecks_when_stored_template_params_unreadable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
