rusackas commented on code in PR #42910: URL: https://github.com/apache/superset/pull/42910#discussion_r4309435168
########## superset-frontend/src/explore/components/controls/IntervalColorsControl/index.tsx: ########## @@ -0,0 +1,103 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { t } from '@apache-superset/core/translation'; +import { getCategoricalSchemeRegistry } from '@superset-ui/core'; +import { isRangesInputComplete } from '@superset-ui/plugin-chart-echarts'; +import ControlHeader from '../../ControlHeader'; +import ColorPickerControl from '../ColorPickerControl'; +import type { ColorPickerValue } from '../ColorPickerControl'; +import { + RangeRow as IntervalRow, + RangeLabel as BoundLabel, + replaceColorAtIndex, +} from '../shared/RangeColorRow'; +import { IntervalColorsControlProps } from './types'; +import { + parseIntervalBounds as parseBounds, + resolveLegacyIntervalColors as resolveLegacyColors, +} from './legacyColors'; + +/** + * Per-interval color editor for the Gauge chart. Row *count* is driven by + * the sibling `intervals` control (one row per parsed upper bound) so bound + * values keep a single source of truth; this control only owns colors, + * stored as an array of hex strings positionally matched to those bounds. + */ +export default function IntervalColorsControl({ + value, + onChange, + intervals, + legacyIntervalColorIndices, + colorScheme, + ...headerProps +}: IntervalColorsControlProps) { + const bounds = parseBounds(intervals); + // `parseBounds` leniently drops blank tokens (e.g. mid-edit "20,,60"), + // which would otherwise shift colors to the wrong bound once the blank is + // filled back in -- same hazard `BulletRangeColorsControl` guards against. + const boundsComplete = isRangesInputComplete(intervals); + const legacyColors = resolveLegacyColors( + bounds, + legacyIntervalColorIndices, + colorScheme, + ); + const schemeColors = + getCategoricalSchemeRegistry().get(colorScheme)?.colors ?? []; + + // Once `interval_colors` is populated the renderer ignores the legacy + // indices and falls back to the scheme's positional color for any missing + // entry, so the display must do the same to avoid persisting a different + // color into an untouched band. + const hasExplicitColors = Array.isArray(value) && value.length > 0; Review Comment: The precedence logic itself was already right, hasExplicitColors covers the partial case the same as the full one, but you'\''re right there was no test pinning that down. Added one with a one-entry value array and legacy indices '\''3,1'\'', checked row 1 shows the scheme'\''s positional color instead of the legacy one, and that editing row 0 does not drag the legacy color into row 1'\''s onChange. ########## superset-frontend/plugins/plugin-chart-echarts/src/Bullet/controlPanel.tsx: ########## @@ -59,6 +62,28 @@ const config: ControlPanelConfig = { }, }, ], + [ + { + name: 'range_colors', Review Comment: Yep, missed that one. The MCP preview now captures range_colors the same pre-sort way Bullet/transformProps.ts does and uses it as a fixed color on the rect layer, falling back to the legend-based coloring when it'\''s unset so an existing Bullet chart previews unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
