codeant-ai-for-open-source[bot] commented on code in PR #45441:
URL: https://github.com/apache/superset/pull/45441#discussion_r4309674374
##########
superset/utils/csv.py:
##########
@@ -102,18 +102,14 @@ def escape_values(v: Any) -> Union[str, Any]:
# Escape csv headers
df = df.rename(columns=escape_values)
- # Escape csv values. Iterate by index label (via ``items``) rather than by
- # positional offset so the escaped value is written back to the correct row
- # even when the DataFrame has a non-default index (e.g. the flattened
- # MultiIndex produced by pivot_table_v2 post-processing). Pairing
positional
- # indices with the label-based ``.at`` accessor would otherwise create
- # phantom rows and corrupt the output. Only string cells are reassigned, so
- # the dtype of mixed object columns (e.g. nullable integers) is preserved.
- for name, column in df.items():
+ # Address cells by position: row and column labels need not be unique, and
+ # escaping column names can turn distinct labels into duplicates. Only
+ # string cells are reassigned to preserve numeric and nullable dtypes.
+ for column_index, (_, column) in enumerate(df.items()):
if pd.api.types.is_string_dtype(column.dtype):
Review Comment:
**Suggestion:** A string-valued `CategoricalDtype` fails this check, so a
cell such as `=1+1` skips `escape_value` and is exported as an executable
spreadsheet formula.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Security`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=2ed2191604374adeae974a6d730f2867&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=2ed2191604374adeae974a6d730f2867&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/csv.py
**Line:** 109:109
**Comment:**
*Security: A string-valued `CategoricalDtype` fails this check, so a
cell such as `=1+1` skips `escape_value` and is exported as an executable
spreadsheet formula.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45441&comment_hash=9e2feeb59edc27e5d446766a11e2e0c7b3636c116201043b005de7d43520156a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45441&comment_hash=9e2feeb59edc27e5d446766a11e2e0c7b3636c116201043b005de7d43520156a&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
