codeant-ai-for-open-source[bot] commented on code in PR #45217:
URL: https://github.com/apache/superset/pull/45217#discussion_r4315750757
##########
.github/actions/setup-backend/action.yml:
##########
@@ -78,3 +82,9 @@ runs:
uv pip install --system -e .
fi
shell: bash
+ - name: Setup Develocity for Python
+ if: inputs.install-superset == 'true' && inputs.develocity-access-key !=
''
+ uses:
gradle/develocity-actions/setup-python@9d8792ab22712b19790c2abce53e9ebb2694c312
# v2.5
+ with:
+ develocity-url: https://develocity.apache.org
+ develocity-access-key: ${{ inputs.develocity-access-key }}
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `1bf5bb4`.
Added `continue-on-error: true` to the Python Develocity setup step so an
agent setup failure does not fail the workflow.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
##########
.github/workflows/superset-translations.yml:
##########
@@ -43,6 +51,11 @@ jobs:
node-version-file: "./superset-frontend/.nvmrc"
cache: "npm"
cache-dependency-path: "superset-frontend/package-lock.json"
+ - name: Setup Develocity for npm
+ if: env.DEVELOCITY_ENABLED == 'true'
+ uses: $/.github/actions/setup-develocity-npm
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `1bf5bb4`.
Guarded the npm Develocity setup step with `steps.check.outputs.frontend`,
so it runs only when frontend files changed.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
