sfirke opened a new issue, #45465:
URL: https://github.com/apache/superset/issues/45465

   ### Bug description
   
   (I used Claude AI to assist in writing up an error I encountered - I have 
read and edited this)
   
   In 7.0.0rc2, when you scroll the SQL Lab results grid, data rows show 
through the column header. The header text and the row underneath it overlap. 
See the top row of my screenshot.
   
   This started with the ag-grid 36 upgrade (#41882). In ag-grid 35 the header 
sat in its own block above the scrolling body, so rows never passed under it. 
In ag-grid 36 the header is a `position: sticky` element 
(`.ag-grid-pinned-top-rows`) inside the same scroll viewport 
(`.ag-grid-viewport`) as the rows, so rows now scroll underneath it.
   
   `ThemedAgGridReact` 
(`packages/superset-ui-core/src/components/ThemedAgGridReact/index.tsx`) sets 
the theme params `backgroundColor: 'transparent'` and `headerBackgroundColor: 
theme.colorFillTertiary`, which in the default theme is `rgba(0,0,0,0.04)`. A 
4% tint over a transparent background is almost fully see-through. That didn't 
matter before 36 but does now that rows pass behind the header.
   
   **The AG Grid Table chart doesn't have this problem.** It uses the same 
`ThemedAgGridReact` and the same theme params, but its `StyledChartContainer` 
(`plugins/plugin-chart-ag-grid-table/src/styles/index.tsx`) sets opaque values 
on the grid's outer container:
   
   ```css
   --ag-background-color: ${theme.colorBgBase};
   --ag-header-background-color: ${theme.colorBgBase};
   ```
   
   These override the transparent theme params, so the chart's sticky header 
paints solid. If I remove those two lines from the chart's container, its 
header becomes see-through on scroll exactly like SQL Lab's. `GridTable` sets 
neither, so SQL Lab results, and anything else built on `GridTable` such as the 
Explore data panel, are affected.
   
   **How to reproduce**
   
   1. In SQL Lab, run any query that returns more rows than fit in the results 
pane, e.g. `SELECT TOP 100 ...` / `... LIMIT 100`.
   2. Scroll the results grid down so that a row sits partly under the header. 
The effect is easiest to see when you stop mid-row.
   3. That row's text, including the row-number column, shows through the 
header text.
   
   **Expected behavior**
   
   The header is opaque and hides the rows that scroll under it, as in 6.x and 
as in the AG Grid Table chart.
   
   **Proposed fix**
   
   Do what the AG Grid Table chart already does: set opaque background 
variables on `GridTable`'s outer container in 
`superset-frontend/src/components/GridTable/index.tsx`:
   
   ```css
   --ag-background-color: ${theme.colorBgBase};
   --ag-header-background-color: ${theme.colorBgBase};
   ```
   
   I tested this against a standalone grid that copies `GridTable`'s CSS and 
options on ag-grid 36.1.0: rows no longer show through the header, and row 
striping and the row-number column look unchanged. One visible difference: the 
header changes from the faint grey tint to plain background color, matching the 
chart.
   
   Two alternatives:
   - To keep the grey tint, set an opaque `headerBackgroundColor` in 
`GridTable`'s `themeOverrides`, i.e. the tint pre-blended onto 
`colorBgContainer`.
   - Making `ThemedAgGridReact`'s defaults opaque would fix every consumer at 
once. But the transparent `backgroundColor` looks deliberate, so that seems 
riskier for other screens.
   
   ### Screenshots/recordings
   
   <img width="1801" height="302" alt="Image" 
src="https://github.com/user-attachments/assets/ac55fa30-e437-46c4-9907-d4973fb5943c";
 />
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   Not applicable
   
   ### Node version
   
   Not applicable
   
   ### Browser
   
   Not applicable
   
   ### Additional context
   
   - Superset 7.0.0rc2, Docker image built from the release (ag-grid-community 
/ ag-grid-react 36.1.0)
   - Introduced by #41882 (ag-grid 35.3.1 → 36.0.0)
   - Not fixed on master as of 2026-10-19
   - Separate from the multi-line cell overlap bug in #45464
   
   ### Checklist
   
   - [x] I have searched Superset docs and Slack and didn't find a solution to 
my problem.
   - [x] I have searched the GitHub issue tracker and didn't find a similar bug 
report.
   - [x] I have checked Superset's logs for errors and if I found a relevant 
Python stacktrace, I included it here as text in the "additional context" 
section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to