sfirke opened a new pull request, #45469: URL: https://github.com/apache/superset/pull/45469
### SUMMARY Removes `plugins/plugin-chart-ag-grid-table/src/utils/useTableTheme.ts`, which nothing imports. The file exports two hooks: - `useTableTheme` (default export) builds a `themeQuartz` light/dark theme. It has never been called: `git log -S useTableTheme` shows only the commit that added it in #33517. The plugin gets its ag-grid theme from `ThemedAgGridReact` instead. - `useIsDark` was used only by `NumericCellRenderer`. That call went away in #41132, which also removed the import but left the file behind. Lint doesn't flag the file because unused-variable checks don't cover unused exports. The plugin's `src/index.ts` doesn't re-export either hook, and the package isn't published to npm, so nothing outside the repo can import it. Removing the file also drops its `tinycolor2` import and the `import/no-extraneous-dependencies` eslint-disable that went with it. `tinycolor2` is still used in `test/utils/useColDefs.test.ts`, so no `package.json` change is needed. No behavior change. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable. ### TESTING INSTRUCTIONS 1. `git grep -nE 'useTableTheme|useIsDark'` returns nothing. 2. `npm run type` and `npm run lint` pass in `superset-frontend`. 3. `npm run test -- plugins/plugin-chart-ag-grid-table` passes. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API --- 🤖 _Drafted by Claude Code, reviewed and approved by @sfirke._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
