gabotorresruiz commented on code in PR #45294: URL: https://github.com/apache/superset/pull/45294#discussion_r4316832764
########## UPDATING.md: ########## @@ -71,8 +71,16 @@ assists people when migrating to a new version. the metric; select a dimension or remove the unsupported predicate. Dashboard filters on incompatible columns (including metrics) are skipped and reported as rejected, so the chart renders with an **Incompatible** filter indicator. - Unknown chart-defined columns are also reported as rejected, matching SQL - datasets. Valid dimension filters are reported as applied. + A chart-defined filter on a column the semantic view no longer has also + returns a client error naming the column, instead of being skipped (which + widened the result); edit the chart's filters and select a dimension. This + differs from SQL datasets, which skip and report such filters. Scheduled + reports, alerts and thumbnails for such charts fail until the chart is edited. + A "No filter" time range is not refused. Reload open dashboards after deploying: + older browser bundles do not mark dashboard filters with `isExtra`, so their + incompatible dashboard filters would be refused as chart filters. A dashboard Review Comment: Thanks, the new wording matches what I measure. Worth putting on the record which shape the qualifier covers: with a dashboard or MCP time range in play, a saved `No filter` or `null` predicate on a metric name is marked and reported as `Incompatible` rather than refused, so that one goes from `400` on `0ce9b6ca46` to `200` here. Bounded predicates on metrics and on missing columns stay refused, which is what this bullet now says, and the chart renders instead of a dashboard filter breaking it, so I think that is the right call. No change needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
