dhruv-techdev commented on PR #45437: URL: https://github.com/apache/superset/pull/45437#issuecomment-6278302443
Good call, thanks @sadpandajoe ! I've added regression tests in tests/unit_tests/jinja_context_test.py: get_filters returns filters with value 0 / False, and marks them as removed with remove_filter=True a native Range filter of 0–100 keeps both the >= 0 and <= 100 bounds filter_values returns 0 / False filter_values still treats "" as absent and falls back to the default (the case CodeAnt flagged) Five of the new tests fail against master and all pass with this change. The full jinja_context_test.py passes locally (211 passed, 1 skipped). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
