younsl commented on PR #462: URL: https://github.com/apache/superset-kubernetes-operator/pull/462#issuecomment-6278397053
Thanks for stepping back on this. I agree with removing it. This came from reading the docs, not from a real need. I have not run into a case where a component had to listen on a different port, and I don't know of a security reason for it either. The Service port already covers the externally visible side. While looking at it again I found one more reason to drop it. Ports set on the top-level podTemplate.container are merged into every component. So a single port added at the top level changes the first port of the web server, Flower, websocket server, and MCP server at once, and all four retarget their Service, probes, and NetworkPolicy to it. My plan for this PR: - Keep each component's primary port fixed to the operator default, so the Service targetPort, default probes, and NetworkPolicy always use it. - Make ports additive: user ports are appended after the primary port, with top-level and component ports merged by name as today. - Don't let a user port take over the primary port's name or number, either by rejecting it through CEL or by letting the operator value win. - Revert the SUPERSET_PORT and MCP --port changes, since they are no longer needed. - Update the ports description in the configuration docs and add a breaking change note to the release notes. Users who override the port today will go back to the default port after upgrading, and the note will say so. I'll retitle the PR to match. For the name or number collision, I lean toward rejecting it through CEL so the mistake shows up at apply time, but I'm happy to go with whichever you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
