rabumaabraham commented on PR #44803: URL: https://github.com/apache/superset/pull/44803#issuecomment-6279222018
@sadpandajoe, Thanks for the thorough review, you were right about the test. I tried the exact flow you described (empty applied entry → Current month → Apply → Clear All) and it already passes on master without my change. The 6.1.0 bug came from the selectedCount !== appliedCount check in checkIsApplyDisabled, and #40470 removed that check on master. So I reverted my index.tsx change, which also takes care of the Undo, cross-filter and initial-load issues. I kept the tests for the real flow so the bug can't come back, and fixed the TypeScript errors and the shared mock. The PR is now tests only. Happy to close it instead if you don't think the extra tests are worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
