fitzee opened a new pull request, #45504: URL: https://github.com/apache/superset/pull/45504
### SUMMARY Local agent evaluations exposed shared-chart edits after dashboard duplication, silently ignored ownership filters, unsupported currency formatting and overconfident interpretation of sampled chart data. This PR updates the MCP contracts and guidance behind those behaviors: - Deep-copy charts by default in `duplicate_dashboard`. Explicit `duplicate_slices=false` remains supported for intentional sharing. - Reject unknown `list_dashboards` fields, including `owned_by_me`, and describe `edited_by_me` as direct user-editor membership. Combined creator/editor filters still return their union. - Include retrieval and sample limits plus a completeness note in dashboard chart data. Histogram output can contain one row after processing capped input; `truncated=false` alone does not establish full-population coverage. - Remove assumed dollars from chart examples and require user instructions or verified metadata for currency formatting. Documents the compatibility changes in `UPDATING.md` and the MCP guide. No frontend, migrations or shell submodule pointer changes. ### TESTING INSTRUCTIONS - 451 tests passed across dashboard schemas, duplication, dashboard data, chart schemas, config coercion and chart-type schemas. Tests ran against this checkout in the existing local test image. - Changed-file pre-commit checks passed except the host custom-Pylint hook, which could not load the Superset runtime. The equivalent custom Pylint check passed separately in the backend test container (10.00/10). Mypy, Ruff, formatting and other applicable hooks passed. CI still needs to validate the standard environment. - No new model eval loop run for this revision. Manual checks: 1. Duplicate a dashboard without `duplicate_slices`; verify the copy has new chart IDs. Repeat with explicit false and verify IDs are shared. 2. Call `list_dashboards` with `owned_by_me`; expect validation failure. Use `edited_by_me` for supported direct-user ownership filtering. 3. Fetch dashboard data with a small fetch limit and verify the limits and completeness note are present, including for histograms. 4. Inspect chart schema/configuration examples for neutral number formatting and evidence-based currency guidance. ### ADDITIONAL INFORMATION Omitting `duplicate_slices` creates additional independent chart objects; callers wanting shared charts must pass false. Unknown dashboard-list arguments fail validation rather than silently broadening a request. The sampling fields are additive and explain existing retrieval behavior; they do not change histogram computation or guarantee full-population results. Currency guidance is descriptive, not a new runtime prohibition. Existing role/access checks are unchanged. - [ ] Has associated issue - [ ] Required feature flags - [ ] Changes UI - [ ] Includes DB Migration - [x] Introduces new feature or API (additive response metadata) - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
