younsl commented on PR #392: URL: https://github.com/apache/superset-kubernetes-operator/pull/392#issuecomment-6279938885
Thanks @villebro, that makes sense. Pushed in [bb404dc](https://github.com/apache/superset-kubernetes-operator/pull/392/commits/bb404dcd8e26b81e2f741861fccfd2d22c02712d): 1. backup.requiresDrain now defaults to true, so the order is drain, backup, then migrate/rotate. 2. Drain stays delete and recreate. On a terminal backup failure, the instance stays drained with the maintenance page up (if configured) until the user retries, fixes, or disables the backup. This reuses the existing terminal failure path, so there is no new controller logic. 3. Unit and e2e tests cover the failure case (maintenance page keeps serving and the Service points to it) and recovery through a pod spec fix, the trigger, or disabling the backup. Docs and the diagram are updated. I kept requiresDrain: false as an opt-out because the field comes from the shared BaseTaskSpec, so removing it only for backup would need a special case. Let me know if you would rather drop it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
